Ignore unavailable storage instead of breaking for all

nextcloud / gallery

DEPRECATED Gallery app was replaced by Photos

https://github.com/nextcloud/photos

GNU Affero General Public License v3.0

109 stars 58 forks source link

Ignore unavailable storage instead of breaking for all #327

Closed blizzz closed 6 years ago

blizzz commented 6 years ago

Fixes: When e.g. a share folder is not available OCP\StorageNotAvailableException is throw, but was never catched. Rendering Gallery broken for everything.

Needs backporting to 12 at least (didn't test 11).

Licence: AGPL

oparoz commented 6 years ago

Failing test is unrelated to this change.

elisman commented 6 years ago

Is anyone fixing the failing test?

oparoz commented 6 years ago

Is anyone fixing the failing test?

Not at the moment.

There are 2 issues 1) The acceptance tests seem to have stopped running. Firefox fails to launch and the CSS selector is wrong 2) The photoshop thumbnail is not retrieved any more. Could be due to changes made in the server for 13 or something we missed in a previous PR