Make acceptance tests run and pass on Travis

desaintmartin commented 6 years ago

Fixes: #329

Licence: AGPL

Description

Make acceptance tests run and pass on Travis by updating the whole toolchain.

Features

Add missing dbus-x11 package needed for Firefox to run (package has been removed in recent Travis images by default)
Update selenium to v3, alongside with geckodriver (only available interface between Webdriver and Firefox in recent Firefox versions)
Add access_log in case of failure, quite useful in a lot of cases
Update Codeception to 2.3 (it appears that it is not related at all to our issue but after testing it does not seem to do any harm)

Caveats

Travis has problems with intermitent failures with acceptance tests regarding login (which is still better than no test at all but far from ideal) that seem impossible to reproduce with local phantomjs.

oparoz commented 6 years ago

Awesome job, many thanks for taking the time to fix this!

desaintmartin commented 6 years ago

You're welcome! Do you have any idea about the intermitent failures? I haven't investigated that much but I think the data is not properly created sometimes (why?), resulting in an error while trying to login. Adding sleeps, trying to login again does not solve it, and I did not have time to dig in the helpers populating the db.

oparoz commented 6 years ago

I'm not sure. I tried to fix this once via one of the PR I submitted, but couldn't get rid of the problem completely :(

nextcloud / gallery