search

nextcloud / gallery

DEPRECATED Gallery app was replaced by Photos
https://github.com/nextcloud/photos
GNU Affero General Public License v3.0
109 stars 58 forks source link

Hide the share drop down when closing the slideshow #354

Closed danxuliu closed 6 years ago

danxuliu commented 6 years ago

The share drop down is shared between the gallery and the slideshow. When the share button of the gallery is clicked the share drop down is shown only if it is not already being shown. However, if the slideshow is closed while the drop down is being shown the gallery considers that the drop down is being shown (even if it is not visible to the user), so clicking on the share button does nothing in that case. Now the drop down is explicitly hidden when the slideshow is closed to ensure that the share button of the gallery works as expected.

Note that the problem was really minor because only the first click after closing the slideshow failed. As that click was not done on the drop down the drop down was closed, so the next time that the button was clicked the drop down was shown as expected.

MorrisJobke commented 6 years ago

Backported and tested: stable13 714a6a2