search

nextcloud / gallery

DEPRECATED Gallery app was replaced by Photos
https://github.com/nextcloud/photos
GNU Affero General Public License v3.0
109 stars 58 forks source link

Unify slideshow share button with the rest of slideshow buttons #356

Closed danxuliu closed 6 years ago

danxuliu commented 6 years ago

The share button is now an input element like the rest of the slideshow buttons.

Besides getting a cleaner code it fixes the share button not being hidden like the rest of the slideshow buttons when the pointer was not moved for three seconds.

This pull request also cleans some related code and adds a tooltip for the Share button.

In the stable12 branch the Share button was hidden, but there was a small glitch: while the rest of the buttons fade from their current opacity (0.5) the Share button first changed to an opacity of 1 and then faded, which made the Share button look like it was highlighted.

If this is worth a backport tell me ;-)

@nextcloud/designers

jancborchardt commented 6 years ago

Could we also use this opportunity to move the share button to the right of the file name? :) And the other actions for Download and Delete should be behind a 3-dot-menu right next to the share icon then, so it's the same as in Files.

The slideshow button can move to the top instead.

What do you think @danxuliu?

jancborchardt commented 6 years ago

(Actually just found #276 again. ;) I updated that one, better to go ahead like that.)

danxuliu commented 6 years ago

@jancborchardt Nextcloud 13 is around the corner, and this pull request fixes a bug, so in my opinion it should be merged before improving the layout, which may not be finished in time (it will depend on how much time others have, because unfortunately I do not have any for it ;-) ).

jancborchardt commented 6 years ago

@danxuliu sure, :+1: then :)

rullzer commented 6 years ago

CI failure needs to be fixed but unrelated here.

@danxuliu if you think this has to be in 13 please open a backport. But I would vote to get it into 13.0.1 then.

danxuliu commented 6 years ago

if you think this has to be in 13 please open a backport.

Done: #368

But I would vote to get it into 13.0.1 then.

I have added it to the Nextcloud 13 milestone, but it would be fine in 13.0.1.

In any case, my question about the backport was more related to the glitch in Nextcloud 12 ;-)