search

nextcloud / gallery

DEPRECATED Gallery app was replaced by Photos
https://github.com/nextcloud/photos
GNU Affero General Public License v3.0
109 stars 58 forks source link

Sharing page header should follow the new layout introduced in Nextcloud 13 #358

Closed danxuliu closed 6 years ago

danxuliu commented 6 years ago

As currently the master branch is compatible only with Nextcloud 13 and later the header shown in the sharing page should follow the new layout introduced in Nextcloud 13.

Right now when the file list is being shown in the sharing page the new header is used, but when the Toggle gallery button is clicked the new header is replaced with the old one.

@nextcloud/designers

danxuliu commented 6 years ago

Related issue in server: https://github.com/nextcloud/server/issues/6553

MorrisJobke commented 6 years ago

Time is up for this one -> 13.0.1

MorrisJobke commented 6 years ago

Will this be ready by later today or should we move it to 13.0.2? https://github.com/nextcloud/server/pull/8748

juliushaertl commented 6 years ago

I would just move this to 14 since we can then use the new PublicPageResponse from https://github.com/nextcloud/server/issues/6553. Otherwise we need to workaround for 13 and do an additional implementation for 14.

Related issue for the PublicPageResponse migration #403

juliushaertl commented 6 years ago

Fix is in #425

MorrisJobke commented 6 years ago

Fixed with #425