search

nextcloud / gallery

DEPRECATED Gallery app was replaced by Photos
https://github.com/nextcloud/photos
GNU Affero General Public License v3.0
109 stars 58 forks source link

Fix "SignInAsUser" acceptance test #377

Closed danxuliu closed 6 years ago

danxuliu commented 6 years ago

Still Developing until the test run and confirm that it is fixed ;-) Mmm, the issue that this pull request meant to fix is fixed, so I am changing it to To review.

However, there is still one test failing in one of the configurations (it seems that the login fails when using PHP 7.0 and MySQL). Maybe a timeout? Is it possible to restart a job in Travis CI?

Fixes #375

The app menu markup has changed in the server. Before, the image had an alt attribute with the name of the app, so calling "click" with the app name was enough (as click uses selectLink, and selectLink selected a clickable image by its alt attribute). However, currently menu icons no longer have that "alt" attribute; as the Gallery text appears in a sibling element of the link clicking on Gallery does nothing, so the link has to be located using an XPath expression instead.

MorrisJobke commented 6 years ago

Is it possible to restart a job in Travis CI?

Just login and press the "Restart job" (one specific job) or "Restart build" (all) button.

oparoz commented 6 years ago

I can't get this test to pass: https://travis-ci.org/nextcloud/gallery/jobs/332938158

It doesn't make sense. It's PHP7 with MySQL. If nobody knows why this fails, we can merge as-is and hope it's just a case of "bad luck".

oparoz commented 6 years ago

My new theory is that PHP7 + MySQL is too slow. That test might have to be changed at some point to wait for the page to be loaded or something like that.

danxuliu commented 6 years ago

My new theory is that PHP7 + MySQL is too slow. That test might have to be changed at some point to wait for the page to be loaded or something like that.

Just for future reference, done in https://github.com/nextcloud/gallery/pull/379