nextcloud / gallery

DEPRECATED Gallery app was replaced by Photos
https://github.com/nextcloud/photos
GNU Affero General Public License v3.0
109 stars 58 forks source link

Require PHPUnit 6.5 #380

Closed danxuliu closed 6 years ago

danxuliu commented 6 years ago

Currently the master branch of the server requires PHPUnit 6.5. The Gallery tests use the TestCase class from the server, which in turn extends the TestCase class from PHPUnit, so the PHPUnit version used in the Gallery must match the one used in the server.

Note that Codeception 2.3.8 is the first version compatible with PHPUnit 6.5; the required Codeception version is set as 2.3.* in composer.json, so there was no need to modify it (as the dependency resolution system of Composer will always get at least 2.3.8 due to the PHPUnit 6.5 constraint).

Reviewers, please note that I have updated the composer.lock file with composer update --no-dev --no-autoloader codeception/codeception phpunit/phpunit myclabs/deep-copy phpunit/php-code-coverage phpunit/php-file-iterator phpunit/phpunit-mock-objects sebastian/comparator sebastian/diff sebastian/environment sebastian/exporter sebastian/global-state sebastian/object-enumerator phpunit/php-token-stream sebastian/recursion-context

Basically I started with composer update --no-dev --no-autoloader codeception/codeception phpunit/phpunit (so it did not install the dev packages and it did not modify the autoloader for the stable packages) and then added failing dependencies until Composer was satisfied (so only the required dependencies were modified). I have no idea if that is the right way to do that :-)