nextcloud / gallery

DEPRECATED Gallery app was replaced by Photos
https://github.com/nextcloud/photos
GNU Affero General Public License v3.0
109 stars 58 forks source link

[stable12] Fix "Sign in as user" acceptance test #385

Closed MorrisJobke closed 6 years ago

MorrisJobke commented 6 years ago

Backport of #377 and #379 (ref #384)

MorrisJobke commented 6 years ago
Unable to create new service: GeckoDriverService
Build info: version: '3.7.1', revision: '8a0099a', time: '2017-11-06T21:07:36.161Z'
System info: host: 'travis-job-nextcloud-gallery-334710089', ip: '172.17.0.10', os.name: 'Linux', os.arch: 'amd64', os.version: '4.14.12-041412-generic', java.version: '1.8.0_151'
Driver info: driver.version: unknown

@danxuliu Any idea what this is about?

danxuliu commented 6 years ago

@MorrisJobke It could be related to #330 but I have not checked it thoroughly yet (and that is the reason why I had backported this PR only to stable13 ;-) ).

Edit: yes, it is fixed by #388

MorrisJobke commented 6 years ago

Rebased to contain #388

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (stable12@4a8569e). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable12     #385   +/-   ##
===========================================
  Coverage            ?   82.27%           
  Complexity          ?      335           
===========================================
  Files               ?       38           
  Lines               ?     1286           
  Branches            ?        0           
===========================================
  Hits                ?     1058           
  Misses              ?      228           
  Partials            ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a8569e...9aaaf6c. Read the comment docs.

MorrisJobke commented 6 years ago

Worked 👍