[stable11] Fix "Sign in as user" acceptance test

nextcloud / gallery

DEPRECATED Gallery app was replaced by Photos

https://github.com/nextcloud/photos

GNU Affero General Public License v3.0

109 stars 58 forks source link

[stable11] Fix "Sign in as user" acceptance test #386

Closed MorrisJobke closed 6 years ago

MorrisJobke commented 6 years ago

Backport of #377 and #379 (ref #384)

MorrisJobke commented 6 years ago

E LoginCept: Ensure that I can see the login page 
PHP Fatal error:  Call to a member function get() on null in /home/travis/build/nextcloud/server/apps/gallery/vendor/codeception/codeception/src/Codeception/Module/WebDriver.php on line 729

@danxuliu @oparoz Any idea about this?

danxuliu commented 6 years ago

@MorrisJobke Weird one... no idea :-O (at least, at this moment ;-) ).

danxuliu commented 6 years ago

@MorrisJobke I have to admit that I do not know why it failed at that point and not earlier (for example, when trying to connect to the browser), but anyway it is fixed by #392.

In any case, note that #377 does not seem to be needed in stable11, as the locator used in the tests works already. #379 does not seem to be strictly needed either, as the tests pass already, although it would make them more robust (but the app menu locator has to be adapted to stable11).