nextcloud / gallery

DEPRECATED Gallery app was replaced by Photos
https://github.com/nextcloud/photos
GNU Affero General Public License v3.0
109 stars 58 forks source link

Fix position of icons in "Share with" input field #412

Closed danxuliu closed 6 years ago

danxuliu commented 6 years ago

This pull request fixes a regression introduced (by me :-P ) in #404.

The box-sizing of #app descendants is set to border-box in the server. Depending on where it is shown, the Share with input field can be a descendant of #app or not, so its icons either use the border-box or the content-box sizing depending on the case (border-box is used when shown in the main gallery layout, while content-box is used when shown in the slideshow layout). Therefore, the padding when using border-box sizing has to be set to the content size (min-width and min-height) plus the padding used in content-box sizing.

Before (share dialog of an album in gallery layout): gallery-share-icon-info-before gallery-share-icon-loading-before

After (share dialog of an album in gallery layout): gallery-share-icon-info-after gallery-share-icon-loading-after

codecov[bot] commented 6 years ago

Codecov Report

Merging #412 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #412   +/-   ##
=========================================
  Coverage     82.55%   82.55%           
  Complexity      360      360           
=========================================
  Files            38       38           
  Lines          1313     1313           
=========================================
  Hits           1084     1084           
  Misses          229      229

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 489562e...83bbc8a. Read the comment docs.