Closed danxuliu closed 6 years ago
Merging #412 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #412 +/- ##
=========================================
Coverage 82.55% 82.55%
Complexity 360 360
=========================================
Files 38 38
Lines 1313 1313
=========================================
Hits 1084 1084
Misses 229 229
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 489562e...83bbc8a. Read the comment docs.
This pull request fixes a regression introduced (by me :-P ) in #404.
The
box-sizing
of#app
descendants is set toborder-box
in the server. Depending on where it is shown, the Share with input field can be a descendant of#app
or not, so its icons either use theborder-box
or thecontent-box
sizing depending on the case (border-box
is used when shown in the main gallery layout, whilecontent-box
is used when shown in the slideshow layout). Therefore, the padding when usingborder-box
sizing has to be set to the content size (min-width
andmin-height
) plus the padding used incontent-box
sizing.Before (share dialog of an album in gallery layout):
After (share dialog of an album in gallery layout):