Closed danxuliu closed 6 years ago
Merging #417 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #417 +/- ##
=========================================
Coverage 82.55% 82.55%
Complexity 360 360
=========================================
Files 38 38
Lines 1313 1313
=========================================
Hits 1084 1084
Misses 229 229
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f413a1e...080539d. Read the comment docs.
Probably not worth a backport, although it should be straightforward to do it.
Let's do it ... stable13 should also fix the paper cuts ;)
Let's do it ... stable13 should also fix the paper cuts ;)
But only if it applies without problems ;)
Let's do it ... stable13 should also fix the paper cuts ;)
But only if it applies without problems ;)
Done; and although I have not checked it, it probably applies without problems on stable12 too if needed ;-)
After calling
Gallery.Share.share
the UI was restored (the working icon was hidden, the input field enabled...). However,share
is asynchronous, so the UI was restored while the share was still being added. Now the UI is restored in the share callbacks, so it is restored once the sharing finished, either successfully or with a failure; in this later case now a notification is also shown.Probably not worth a backport, although it should be straightforward to do it.
How to test
sleep(10);
to the beginning of thecreate
method to simulate a slow serverExpected result The input field is disabled and the working icon is shown until the share is finally added.
Actual result The input field is enabled and the working icon is hidden immediately.