nextcloud / gallery

DEPRECATED Gallery app was replaced by Photos
https://github.com/nextcloud/photos
GNU Affero General Public License v3.0
109 stars 58 forks source link

Public page response #425

Closed juliushaertl closed 6 years ago

juliushaertl commented 6 years ago

Use the new PublicPageResponse for NC14+ to render public pages that have the same header actions as the files_sharing app.

Fixes https://github.com/nextcloud/gallery/issues/403 and https://github.com/nextcloud/gallery/issues/358

Requires https://github.com/nextcloud/server/pull/9084

image

juliushaertl commented 6 years ago

Tests are fixed, they still fail because the new classes from nextcloud/server#9084 are not available. Once that is merged they should run fine.

MorrisJobke commented 6 years ago

Tests are fixed, they still fail because the new classes from nextcloud/server#9084 are not available. Once that is merged they should run fine.

Retriggered them, because server PR was merged.

codecov[bot] commented 6 years ago

Codecov Report

Merging #425 into master will increase coverage by 0.05%. The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #425      +/-   ##
============================================
+ Coverage     82.55%   82.61%   +0.05%     
  Complexity      360      360              
============================================
  Files            38       38              
  Lines          1313     1323      +10     
============================================
+ Hits           1084     1093       +9     
- Misses          229      230       +1
Impacted Files Coverage Δ Complexity Δ
lib/AppInfo/Application.php 74.37% <0%> (-0.38%) 28 <0> (ø)
lib/Controller/PageController.php 100% <100%> (ø) 12 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ac64fa1...bef5857. Read the comment docs.

oparoz commented 6 years ago

Look at all this beautiful green :)