Exif description - Githubissues

nextcloud / gallery

DEPRECATED Gallery app was replaced by Photos

https://github.com/nextcloud/photos

GNU Affero General Public License v3.0

109 stars 58 forks source link

Exif description #426

Closed turb closed 4 years ago

turb commented 6 years ago

Licence: MIT or AGPL

Description

Port of @0xb0ba Exif Description PR to Nextcloud gallery.

Features

replaces the display of the filename with any description found in the image EXIF properties, when displaying a picture

Screenshots or screencasts

See https://github.com/owncloud/gallery/pull/453

Tests

Test plan

Tested with exif:ImageDescription set by Apple.

Not tested with iptc:APP13 (IPTC:Description) (?) set by other manufacturers like Adobe.

Tested on

Mac OS X/Firefox
Mac OS X/Safari
Mac OS X/Chromium
Android 4.4/Chrome

TODO

also display it on each caption in the gallery?

Check list

[x] Code is properly documented
[x] Code is properly formatted
[ ] Commits have been squashed
[ ] Tests (unit, integration, api and/or acceptance) are included
[ ] Documentation (manuals or wiki) has been updated or is not required

Reviewers

oparoz commented 6 years ago

My main problem with this is that this is parsing the exif data for every image and will slow down the rendering for people who do not care about showing exif data.

Maybe we could make it optional using a configuration switch in gallery.cnf while we wait for exif data to be properly collected and stored in the DB at upload time.

turb commented 6 years ago

@oparoz the EXIF extraction is triggered by a JS async call after the rendering, to it should not slow it.

I do not know enough about OC/NC code to implement DB storage right now, maybe someone can.

oparoz commented 6 years ago

@oparoz the EXIF extraction is triggered by a JS async call after the rendering, to it should not slow it.

Good point, so this should be reviewed to be included in a future release.

turb commented 6 years ago

Good point, so this should be reviewed to be included in a future release.

@oparoz thanks, any idea if it can be done before next release?

oparoz commented 6 years ago

We need people to test and review this PR. There is still 2 months to make it in the next release. 🤞

turb commented 5 years ago

@oparoz do you think it may be possible having someone review this one?

MorrisJobke commented 5 years ago

If the description is too long then not everything is shown. Maybe instead of replacing the name just showing it via the tooltip that is shipped in Nextcloud is the better approach (see for example the tooltips on the elements in the files sidebar).

I used the "long_description.jpg" from https://github.com/ianare/exif-samples/tree/master/jpg

nickvergessen commented 4 years ago

The gallery app has been replaced by the beautiful new app: Nextcloud Photos - :camera_flash: Your memories under your control

Please checkout if your Pull request is still necessary there, and in case create it there or raise an issue for others to copy the change from here.