search

nextcloud / gallery

DEPRECATED Gallery app was replaced by Photos
https://github.com/nextcloud/photos
GNU Affero General Public License v3.0
109 stars 58 forks source link

Add livephotos support #434

Closed fefux closed 4 years ago

fefux commented 6 years ago

Add livephotos support from Apple :

To work, a .jpg/.JPG picture needs to have beside a .mov/.MOV video with the same name

Signed-off-by: François Sylvestre francoissylv@gmail.com

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@dcd272d). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #434   +/-   ##
=========================================
  Coverage          ?   82.62%           
  Complexity        ?      360           
=========================================
  Files             ?       38           
  Lines             ?     1324           
  Branches          ?        0           
=========================================
  Hits              ?     1094           
  Misses            ?      230           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
lib/Controller/PageController.php 100% <100%> (ø) 12 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dcd272d...50c3748. Read the comment docs.

jancborchardt commented 6 years ago

Thanks a lot for your contribution @fefux! :tada: And sorry for the late reply.

Could someone with macOS or iPhone look into this? @nextcloud/mac :green_apple:

fefux commented 6 years ago

I just noticed that my pullrequest breaks the default slideshow in nextcloud. So I'm fixing the bug and I will update the PR.

jospoortvliet commented 6 years ago

@fefux thanks, esp given we're close to the 14 release :1st_place_medal: - I think we should try to get this in if we still can... If not, 15 :2nd_place_medal:

fefux commented 6 years ago

Just before going in vacation, I tested a functional patch. The issue is the default slideshow is override by the one in gallery but additional dependencies for livephoto not. I don't have my laptop so I can't do the pullrequest before the 20th. @jospoortvliet I saw release date for release 14 is the 29th. I will do my possible but it seems quite close to do review and tests before merging in time.

MorrisJobke commented 5 years ago

@fefux Even if this is a super nice feature, time runs up and we need to move this to Nextcloud 15, which is planned for December. I hope this is okay for you?

fefux commented 5 years ago

No problem for me, in addition this functionnality is eventually more usefull if nextcloud app for iphone supports importation of live photo too (which seems not be the case now).

AndreiButoi commented 5 years ago

I saw that ios live photos support was removed from the Nextcloud 15 milestone. Will still be developed?

fefux commented 5 years ago

Hi everybody, sorry for the late, I just updated the code for support livephoto for nextcloud 15.0.4 and with the tip of the branch. @AndreiButoi development still on going. I see that my pullrequest have many problems with CI tools. Is my code is in fault or is tools/tests need to be updated (for example, I saw an error with signed-off for CI/drone, but my commit contains a signed off)? Have a nice day

SimonSelg commented 5 years ago

@fefux do you need some help on this? I'd be willing to work on this issue as I need it myself :)

MorrisJobke commented 5 years ago

Joe do you extract those two files from an iPhone? We tried to extract this, but it always just exported the jpeg file without the mov.

Also @skjnldsv is working on bringing this to the viewer (see repo at nextcloud/viewer repo)

maci2100 commented 5 years ago

Something new here ?

skjnldsv commented 5 years ago

Something new here ?

This is already in the new viewer :)

MorrisJobke commented 5 years ago

https://github.com/nextcloud/viewer <- this unifies the different viewers of gallery, text editor, PDF, etc and replaces the slideshow from the gallery app.

k1l1 commented 5 years ago

Is it already released in NC 16? I doesn't work for me. When I use the viewer in a folder which contains IMG_4112.JPG and IMG_4112.MOV one is shown as picture, the other as video. What is the expected behaviour?

skjnldsv commented 5 years ago

@k1l1 nc 17

thibaultamartin commented 4 years ago

@skjnldsv will this actually be in Nextcloud 17? It looks like it will wait for NC18 at the very least, doesn’t it?

skjnldsv commented 4 years ago

@skjnldsv will this actually be in Nextcloud 17? It looks like it will wait for NC18 at the very least, doesn’t it?

We now ship a new viewer since 16. Not the gallery, on files. It now sypport livephotos that are split into jpg/video in the same dir :)

thibaultamartin commented 4 years ago

We now ship a new viewer since 16. Not the gallery, on files.

Okay so just to make sure I'm getting it right: let's consider I upload a Live Photo from my iPhone automatically using Nextcloud's app. A new folder with the photo + video of the Live Photo is created in my /Photo folder. If I browse to said folder using my instance's file explorer, the file viewer will display it as a Live Photo. If I browse my Gallery, I will see a photo and a video. Is this right?

It now sypport livephotos that are split into jpg/video in the same dir :)

It may not belong here, but still has some ties with the gallery I think: if I upload a Live Photo from my phone to the Gallery, wipe the phone, and download back what was uploaded to my instance, will I have a Live Photo or a photo+video on my phone?

Thanks for your answers and work @skjnldsv, it's really helpful :)

skjnldsv commented 4 years ago

will I have a Live Photo or a photo+video on my phone

I cannot tell. This is something to check with your phone :)

If I browse my Gallery, I will see a photo and a video. Is this right?

Right! :) The gallery is a bit old and unusable as is. We currently have the grid view which is similar

thibaultamartin commented 4 years ago

Crystal clear, thanks! All this leads me to think that gallery is going to be either deprecated or deeply changed. Is this the case?

skjnldsv commented 4 years ago

Crystal clear, thanks! All this leads me to think that gallery is going to be either deprecated or deeply changed. Is this the case?

Yes :)

adutta98 commented 4 years ago

Crystal clear, thanks! All this leads me to think that gallery is going to be either deprecated or deeply changed. Is this the case?

Yes :)

So if I understand this right, the requirement for this to work is a jpg/mov combo, is there any chance it would also work with a HEIC/mov combo, files of the same name? or any wip for it?

Thanks for all the good work.

skjnldsv commented 4 years ago

jpg/mov combo

Not only, any image/video combo is fine :)

would also work with a HEIC/mov combo

We just need to support heic then, but that's a tricky part since heic can contains lots of stuff: multiple images, videos...

logo000 commented 4 years ago

Hello, First, I love your work. Nextcloud is a awesome program. Iam a iOS User and my love are Live Photos. This is the only Feature that not implemented yet. So is there any progress or eta for this feature? Thx. So much <3

nickvergessen commented 4 years ago

The gallery app has been replaced by the beautiful new app: Nextcloud Photos - :camera_flash: Your memories under your control

Please checkout if your Pull request is still necessary there, and in case create it there or raise an issue for others to copy the change from here.