nextcloud / gallery

DEPRECATED Gallery app was replaced by Photos
https://github.com/nextcloud/photos
GNU Affero General Public License v3.0
109 stars 58 forks source link

Trying to add video support, failing to get past validation #440

Open mrzapp opened 6 years ago

mrzapp commented 6 years ago

Feature request

User type: Logged-in

User level: Beginners

Description

I am trying to add experimental video support for mp4, webm and ogg, since these formats are well-supported in all modern browsers now.

I have added the mime types in the base media types array in /lib/Service/ConfigService.php around line 55:

However, I get stuck at the validation step, the function "validateMimeType" seems to ignore my changes to the array, even though the "getSupportedMediaTypes" function uses it directly. Is it cached somewhere, or what gives?

The "/gallery/files/list" endpoint is being requested with the new media types, though, it's just the preview that throws the exception.

Benefit / value

It's just a missing feature from the gallery app. Too many users upload videos to their galleries to ignore this need.

Risk / caveats

Not all mime types are supported by browsers, and probably never will. We are limited to mp4, webm and ogg, but it's better than nothing

Sponsorship

Are you a developer willing to implement this feature?: yes

Can you sponsor the development of this feature or do you know someone who can?: yes