Add HEIC/HEIF support to the gallery

steiny2k commented 5 years ago

Requires:

Fixes: https://github.com/owncloud/gallery/issues/737

Licence: AGPL

Description

This is just adding the mime type for apple iPhone HEIC files to the $baseMimeTypes

Features

renders HEIC files as thumbnails and in the slideshow

Screenshots or screencasts

Caveats

needs nextcloud 14

Tests

Test plan

Upload a test image
Make sure it gets rendered as a thumbnail in gallery
Make sure it gets rendered in slideshow
Make sure it can be downloaded from slideshow

Tested on

[X] macOS / Firefox
[X] macOS / Safari

TODO

[ ] Other test-cases (?)

Check list

[ ] Code is properly documented
[ ] Code is properly formatted
[x] Commits have been squashed
[ ] Tests (unit, integration, api and/or acceptance) are included
[ ] Documentation (manuals or wiki) has been updated or is not required

Reviewers

@MorrisJobke @rullzer @oparoz

steiny2k commented 5 years ago

Hi, the CI tests fail. I'm wondering whether that's due to my changes, or whether that's a known issue with the tests at the moment. As the change is really tiny, I can't believe it's due to that...

blizzz commented 5 years ago

set the milestone to 15 as it is against master.

tests in gallery are broken anyway, there's another ticket about it 🙊

nextcloud / gallery