nextcloud / gallery

DEPRECATED Gallery app was replaced by Photos
https://github.com/nextcloud/photos
GNU Affero General Public License v3.0
109 stars 58 forks source link

Files/image viewer: Icons invisible in dark mode #483

Closed sgofferj closed 5 years ago

sgofferj commented 5 years ago

When the system is set to dark template, icons in the image viewer are invisible. That is the image viewer in the files app, not the gallery app. The problem is more than just cosmetic because not only the "close viewer" icon is invisible but also the "delete file" icon which might lead to accidental file deletions.

Steps to reproduce

  1. Switch to dark mode
  2. Click on an image file in files app to view it
  3. Search icons

Expected behaviour

Icons should be visible

Actual behaviour

Icons are not visible - presumably black on black

Server configuration

Operating system: Ubuntu 16.04

Web server: Apache 2

Database: MariaDB

PHP version: 7.2

Nextcloud version: (see Nextcloud admin page) 14.0.3

Updated from an older Nextcloud/ownCloud or fresh install: Updated from Owncloud long ago

Where did you install Nextcloud from: Update procedure from Owncloud according to migration guide

Signing status:

Signing status ``` No errors have been found. ```

List of activated apps:

App list ``` Enabled: - accessibility: 1.0.1 - activity: 2.7.0 - announcementcenter: 3.3.1 - apporder: 0.5.0 - audioplayer: 2.4.1 - bookmarks: 0.13.1 - bruteforcesettings: 1.1.0 - calendar: 1.6.3 - cloud_federation_api: 0.0.1 - comments: 1.4.0 - contacts: 2.1.6 - dav: 1.6.0 - deck: 0.4.1 - dicomviewer: 1.0.2 - external: 3.1.0 - federatedfilesharing: 1.4.0 - federation: 1.4.0 - files: 1.9.0 - files_automatedtagging: 1.4.0 - files_external: 1.5.0 - files_markdown: 2.0.4 - files_pdfviewer: 1.3.2 - files_sharing: 1.6.2 - files_texteditor: 2.6.0 - files_trashbin: 1.4.1 - files_versions: 1.7.1 - files_videoplayer: 1.3.0 - firstrunwizard: 2.3.0 - gallery: 18.1.0 - gpxpod: 2.3.1 - groupfolders: 1.3.3 - impersonate: 1.1.0 - logreader: 2.0.0 - lookup_server_connector: 1.2.0 - nextcloud_announcements: 1.3.0 - notes: 2.4.2 - notifications: 2.2.1 - oauth2: 1.2.1 - password_policy: 1.4.0 - passwords: 2018.11.0 - provisioning_api: 1.4.0 - serverinfo: 1.4.0 - sharebymail: 1.4.0 - socialsharing_facebook: 1.0.3 - socialsharing_twitter: 1.0.3 - spreed: 4.0.0 - support: 1.0.0 - systemtags: 1.4.0 - tasks: 0.9.7 - theming: 1.5.0 - twofactor_backupcodes: 1.3.1 - updatenotification: 1.4.1 - workflowengine: 1.4.0 Disabled: - admin_audit - encryption - survey_client - user_external - user_ldap - user_pwauth ```

Nextcloud configuration:

Config report ``` "system": { "instanceid": "***REMOVED SENSITIVE VALUE***", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "home.gofferje.net" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "overwrite.cli.url": "https:\/\/home.gofferje.net\/cloud", "htaccess.RewriteBase": "\/cloud", "dbtype": "mysql", "version": "14.0.3.0", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbtableprefix": "oc_", "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true, "theme": "", "maintenance": false, "asset-pipeline.enabled": false, "loglevel": 4, "trashbin_retention_obligation": "auto", "defaultapp": "files", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_smtpmode": "smtp", "mail_smtpauthtype": "LOGIN", "mail_domain": "***REMOVED SENSITIVE VALUE***", "ldapIgnoreNamingRules": false, "ldapProviderFactory": "\\OCA\\User_LDAP\\LDAPProviderFactory", "memcache.locking": "\\OC\\Memcache\\Redis", "memcache.local": "\\OC\\Memcache\\Redis", "redis": { "host": "***REMOVED SENSITIVE VALUE***", "port": 6379 }, "mail_smtpsecure": "tls", "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "587" } } ```

Are you using external storage, if yes which one: local/smb/sftp/... SMB - however, bug appears also on internal storage

Are you using encryption: yes/no no

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/... no

Client configuration

Browser: Firefox 63

Operating system: Linux and Windows

nextcloud-bot commented 5 years ago

GitMate.io thinks possibly related issues are https://github.com/nextcloud/server/issues/8241 (image), https://github.com/nextcloud/server/issues/3921 (Firefox: Icons invisible in app menu), https://github.com/nextcloud/server/issues/12091 (Loading dark icon not visible enough), https://github.com/nextcloud/server/issues/1692 (Dark mode accessibility ), and https://github.com/nextcloud/server/pull/10378 (Fix icon file names).

MorrisJobke commented 5 years ago

When the system is set to dark template, icons in the image viewer are invisible. That is the image viewer in the files app, not the gallery app.

This is provided by the gallery app itself. cc @skjnldsv @oparoz

skjnldsv commented 5 years ago

Fixed already in the new viewer