search

nextcloud / gallery

DEPRECATED Gallery app was replaced by Photos
https://github.com/nextcloud/photos
GNU Affero General Public License v3.0
109 stars 58 forks source link

Deleting an image while gallery is open doesn't refresh list view #513

Closed LordSimal closed 4 years ago

LordSimal commented 5 years ago

Bug report

Steps to reproduce

  1. Open a folder with some images
  2. Open an image to show the gallery
  3. Delete the current open image with the trash icon on the top right
  4. Close the Gallery View
  5. The deleted image is still visible in the list view

Expected behaviour

The deleted image should not be present in the list view. When you delete an image while the gallery view is open it should update the list view.

Actual behaviour

The deleted image is still visible in the list view and you can open the gallery view "again" with this image.

Server configuration

Operating system: Ubuntu 18.04.2 LTS

Web server: nginx/1.14.0

Database: MariaDB 10.3.14

PHP version: 7.2.17

Nextcloud configuration

Nextcloud version:
15.0.7.0

Updated from an older installation or fresh install: updated from older installation

List of activated apps:

App list ``` Enabled: - accessibility: 1.1.0 - activity: 2.8.2 - bruteforcesettings: 1.3.0 - calendar: 1.6.4 - cloud_federation_api: 0.1.0 - comments: 1.5.0 - contacts: 3.1.0 - dav: 1.8.1 - federatedfilesharing: 1.5.0 - federation: 1.5.0 - files: 1.10.0 - files_pdfviewer: 1.4.0 - files_sharing: 1.7.0 - files_texteditor: 2.7.0 - files_trashbin: 1.5.0 - files_versions: 1.8.0 - files_videoplayer: 1.4.0 - firstrunwizard: 2.4.0 - gallery: 18.2.0 - logreader: 2.0.0 - lookup_server_connector: 1.3.0 - metadata: 0.9.0 - nextcloud_announcements: 1.4.0 - notifications: 2.3.0 - oauth2: 1.3.0 - password_policy: 1.5.0 - previewgenerator: 2.1.0 - provisioning_api: 1.5.0 - serverinfo: 1.5.0 - sharebymail: 1.5.0 - support: 1.0.0 - survey_client: 1.3.0 - systemtags: 1.5.0 - theming: 1.6.0 - twofactor_backupcodes: 1.4.1 - twofactor_totp: 2.1.2 - updatenotification: 1.5.0 - workflowengine: 1.5.0 Disabled: - admin_audit - encryption - files_external - user_ldap ```

Nextcloud configuration:

Config.php ``` { "system": { "instanceid": "***REMOVED SENSITIVE VALUE***", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "overwrite.cli.url": "https:\/\/", "dbtype": "mysql", "version": "15.0.7.0", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbtableprefix": "oc_", "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "logtimezone": "UTC", "installed": true, "loglevel": 1, "tempdirectory": "cloud_tmp", "maintenance": false, "htaccess.RewriteBase": "\/", "theme": "", "mail_smtpmode": "smtp", "mail_smtpsecure": "tls", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtpauthtype": "LOGIN", "mail_smtpauth": 1, "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "25", "mail_smtpname": "***REMOVED SENSITIVE VALUE***", "mail_smtppassword": "***REMOVED SENSITIVE VALUE***", "memcache.local": "\\OC\\Memcache\\APCu", "preview_max_x": 1920, "preview_max_y": 1080, "preview_max_scale_factor": 1, "mysql.utf8mb4": true } } ```

Are you using external storage, if yes which one: No

Are you using encryption: No

Are you using custom gallery.cnf config files: No

Web server error log

Web server error log ``` 2019/04/13 22:34:45 [warn] 4286#4286: *1468 an upstream response is buffered to a temporary file /var/lib/nginx/fastcgi/4/11/0000000114 while reading upstream, client: 91.224.71.106, server: , request: "GET /core/preview?fileId=244725&c=7f61b08241624a9e63cf418d01e8fb19&x=500&y=500&forceIcon=0 HTTP/2.0", upstream: "fastcgi://unix:/run/php/php7.2-fpm-nextcloud.sock:", host: "" 2019/04/13 22:34:46 [warn] 4286#4286: *1468 an upstream response is buffered to a temporary file /var/lib/nginx/fastcgi/5/11/0000000115 while reading upstream, client: 91.224.71.106, server: , request: "GET /core/preview?fileId=244729&c=2922ed66275dbb6f7294468c89827992&x=500&y=500&forceIcon=0 HTTP/2.0", upstream: "fastcgi://unix:/run/php/php7.2-fpm-nextcloud.sock:", host: "" 2019/04/13 22:34:46 [warn] 4286#4286: *1468 an upstream response is buffered to a temporary file /var/lib/nginx/fastcgi/6/11/0000000116 while reading upstream, client: 91.224.71.106, server: , request: "GET /core/preview?fileId=244731&c=f82c282282ea2f1b07effe44f3a622aa&x=500&y=500&forceIcon=0 HTTP/2.0", upstream: "fastcgi://unix:/run/php/php7.2-fpm-nextcloud.sock:", host: "" 2019/04/13 22:34:47 [warn] 4286#4286: *1468 an upstream response is buffered to a temporary file /var/lib/nginx/fastcgi/7/11/0000000117 while reading upstream, client: 91.224.71.106, server: , request: "GET /core/preview?fileId=244753&c=369a91f71663ad0aedf4d33760259c33&x=500&y=500&forceIcon=0 HTTP/2.0", upstream: "fastcgi://unix:/run/php/php7.2-fpm-nextcloud.sock:", host: "" 2019/04/13 22:34:47 [warn] 4286#4286: *1468 an upstream response is buffered to a temporary file /var/lib/nginx/fastcgi/8/11/0000000118 while reading upstream, client: 91.224.71.106, server: , request: "GET /core/preview?fileId=244754&c=fad9821437730fbb4ae9fcdf6babaa07&x=500&y=500&forceIcon=0 HTTP/2.0", upstream: "fastcgi://unix:/run/php/php7.2-fpm-nextcloud.sock:", host: "" 2019/04/13 22:34:47 [warn] 4286#4286: *1468 an upstream response is buffered to a temporary file /var/lib/nginx/fastcgi/9/11/0000000119 while reading upstream, client: 91.224.71.106, server: , request: "GET /core/preview?fileId=244765&c=e92e46d312aaf02afcb582b213e2627e&x=500&y=500&forceIcon=0 HTTP/2.0", upstream: "fastcgi://unix:/run/php/php7.2-fpm-nextcloud.sock:", host: "" 2019/04/13 22:34:48 [warn] 4286#4286: *1468 an upstream response is buffered to a temporary file /var/lib/nginx/fastcgi/0/12/0000000120 while reading upstream, client: 91.224.71.106, server: , request: "GET /core/preview?fileId=244766&c=c7c52d26752b099e823069a8a8ff1b11&x=500&y=500&forceIcon=0 HTTP/2.0", upstream: "fastcgi://unix:/run/php/php7.2-fpm-nextcloud.sock:", host: "" 2019/04/13 22:34:48 [warn] 4286#4286: *1468 an upstream response is buffered to a temporary file /var/lib/nginx/fastcgi/1/12/0000000121 while reading upstream, client: 91.224.71.106, server: , request: "GET /core/preview?fileId=244771&c=f2ffc88bdbe27f0b88dbbe73194d091e&x=500&y=500&forceIcon=0 HTTP/2.0", upstream: "fastcgi://unix:/run/php/php7.2-fpm-nextcloud.sock:", host: "" 2019/04/13 22:36:04 [warn] 4286#4286: *1468 an upstream response is buffered to a temporary file /var/lib/nginx/fastcgi/2/12/0000000122 while reading upstream, client: 91.224.71.106, server: , request: "GET /settings/apps/list HTTP/2.0", upstream: "fastcgi://unix:/run/php/php7.2-fpm-nextcloud.sock:", host: "" 2019/04/13 22:43:54 [warn] 4286#4286: *1468 an upstream response is buffered to a temporary file /var/lib/nginx/fastcgi/3/12/0000000123 while reading upstream, client: 91.224.71.106, server: , request: "GET /apps/gallery/preview/244753?width=3400&height=3400&c=369a91f71663ad0aedf4d33760259c33&requesttoken=fYlNXK6dxRWPO%2BVxPoh7NFrhu4nZ2li4S0PXNwPeNAo%3D%3ASP8kJdnPhH3taLFIe%2B4YbSOF8MSOjD%2FIH3CzT0y6ZEg%3D HTTP/2.0", upstream: "fastcgi://unix:/run/php/php7.2-fpm-nextcloud.sock:", host: "" 2019/04/13 22:47:23 [error] 4286#4286: *1468 access forbidden by rule, client: 91.224.71.106, server: , request: "GET /data/.ocdata?t=1555188443372 HTTP/2.0", host: "" 2019/04/13 22:47:29 [error] 4286#4286: *1468 access forbidden by rule, client: 91.224.71.106, server: , request: "GET /data/.ocdata?t=1555188449329 HTTP/2.0", host: "" ```

Nextcloud log

Nextcloud log ``` {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:15+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::info: Repair info: 0 tags with no entries have been removed.","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:15+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::step: Repair step: Repair invalid shares","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:15+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::step: Repair step: Remove shares of a users root folder","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:15+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::step: Repair step: Move .step file of updater to backup location","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:15+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::info: Repair info: .step file exists","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:15+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::info: Repair info: .step-previous-update removed","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:15+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::info: Repair info: .step file moved to .step-previous-update","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:15+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::step: Repair step: Fix potential broken mount points","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:15+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::info: Repair info: No mounts updated","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:15+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::step: Repair step: Repair invalid paths in file cache","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:15+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::step: Repair step: Add log rotate job","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:15+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::step: Repair step: Clear frontend caches","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:15+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::info: Repair info: Image cache cleared","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:16+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::info: Repair info: SCSS cache cleared","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:17+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::info: Repair info: JS cache cleared","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:17+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::step: Repair step: Clear every generated avatar on major updates","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:17+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::step: Repair step: Add preview background cleanup job","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:17+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::step: Repair step: Queue a one-time job to cleanup old backups of the updater","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:17+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::step: Repair step: Repair pending cron jobs","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:17+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::info: Repair info: No need to repair pending cron jobs.","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:17+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Repair::step: Repair step: Extract the vcard uid and store it in the db","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:17+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Updater::startCheckCodeIntegrity: Starting code integrity check...","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:20+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Updater::finishedCheckCodeIntegrity: Finished code integrity check","userAgent":"--","version":"15.0.6.1"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:20+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Updater::updateEnd: Update successful","userAgent":"--","version":"15.0.7.0"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:20+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Updater::maintenanceActive: Maintenance mode is kept active","userAgent":"--","version":"15.0.7.0"} {"reqId":"6p5sXQBE5SwlYCHI1qqV","level":1,"time":"2019-04-09T12:49:20+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Updater::resetLogLevel: Reset log level to Info(1)","userAgent":"--","version":"15.0.7.0"} {"reqId":"ZFKmOx45KmPPMUp0oPnb","level":1,"time":"2019-04-09T13:00:02+00:00","remoteAddr":"","user":"--","app":"no app in context","method":"","url":"--","message":"httpdocs\/data\/updater-oc7nj6csico6\/backups exists - start to clean it up","userAgent":"--","version":"15.0.7.0"} {"reqId":"ZFKmOx45KmPPMUp0oPnb","level":1,"time":"2019-04-09T13:00:02+00:00","remoteAddr":"","user":"--","app":"no app in context","method":"","url":"--","message":"List of all directories that will be deleted: [\"/httpdocs\\\/data\\\/updater-oc7nj6csico6\\\/backups\\\/nextcloud-15.0.2.0\"]","userAgent":"--","version":"15.0.7.0"} {"reqId":"ZFKmOx45KmPPMUp0oPnb","level":1,"time":"2019-04-09T13:00:02+00:00","remoteAddr":"","user":"--","app":"no app in context","method":"","url":"--","message":"Removing httpdocs\/data\/updater-oc7nj6csico6\/backups\/nextcloud-15.0.2.0 ...","userAgent":"--","version":"15.0.7.0"} {"reqId":"ZFKmOx45KmPPMUp0oPnb","level":1,"time":"2019-04-09T13:00:03+00:00","remoteAddr":"","user":"--","app":"no app in context","method":"","url":"--","message":"Cleanup finished","userAgent":"--","version":"15.0.7.0"} ```

Client configuration

Browser: 73.0.3683.103

Operating system: MacOS Mojave 10.14.4

Browser log

Browser log ``` JQMIGRATE: Migrate is installed, version 1.4.0 DevTools failed to parse SourceMap: https:///apps/notifications/js/notifications.js.map ```
skjnldsv commented 4 years ago

Hey! When you say on the view, you mean still on the gallery or in the files app? Deleting in the slideshow doesn't update the gallery grid view?

LordSimal commented 4 years ago

Since there is no trash icon any more in the "single image view" this problem is no longer reproducible.

As described above there was a trash icon in the "large" view when you open an image. And after you have clicked on that trash icon to remove the current open image the list view in the back hasn't been updated.

But we can close this issue due to the fact, that some update since the 13th of April has removed the trash icon from the "single image view".