nextcloud / gallery

DEPRECATED Gallery app was replaced by Photos
https://github.com/nextcloud/photos
GNU Affero General Public License v3.0
109 stars 58 forks source link

Blacklist using .noimage #520

Closed tnyeanderson closed 5 years ago

tnyeanderson commented 5 years ago

Fixes: #438

Licence: MIT or AGPL

Description

Supports blacklisting folders by creating a .noimage file.

Features

Screenshots or screencasts

Caveats

Tests

Tested on my system

Test plan

Tested on

TODO

Check list

Reviewers

tnyeanderson commented 5 years ago

Why did travis-ci fail?

nickvergessen commented 5 years ago

Why is .nomedia not enough?

You can ignore failing travis CI for now.

tnyeanderson commented 5 years ago

Because .nomedia is used by so many apps/scanners, it can have undesirable effects. For instance, I may have a folder for a music album that contains mp3 files and an image for the album cover. If I use .nomedia because I don't want the image to appear in the gallery, the mp3 files won't appear in any music playing apps either because the whole folder will be ignored. It is nice to have an app-specific option to ignore a folder rather than trying to use such a global indicator to do it, potentially messing up other parts of your workflow.

Hope this explains the need.

nickvergessen commented 5 years ago

Yeah sounds good :+1:

tnyeanderson commented 5 years ago

Can you approve? :)

tnyeanderson commented 5 years ago

Thank you for the excellent suggestions! Will have to wait until I get home to commit the new changes. Will you have to reapprove once I do that? Would love to get this out of my queue......

blizzz commented 5 years ago

I think we can merge once the requested changes are in

tnyeanderson commented 5 years ago

Sorry for the delay, the day job caught up to me this week :)

nickvergessen commented 5 years ago

/backport to stable16

backportbot-nextcloud[bot] commented 5 years ago

backport to stable16 in #533