search

nextcloud / gallery

DEPRECATED Gallery app was replaced by Photos
https://github.com/nextcloud/photos
GNU Affero General Public License v3.0
109 stars 58 forks source link

Hide download feature not working for folders #523

Open ravi-gh opened 5 years ago

ravi-gh commented 5 years ago

Bug report

Steps to reproduce

  1. Share a folder with images in the Files section of Nextcloud, making sure the "Hide download" checkbox is checked.
  2. Open the folder in Gallery app and copy the sharing link.
  3. Use the link to share the Gallery view with others

Expected behaviour

When somebody open the link, the "Download" buttons in gallery view and slideshow view should not be visible.

Actual behaviour

When they open the link, the "Download" buttons in both gallery view and slideshow view are visible.

Server configuration

Nextcloud configuration

Nextcloud version: Nextcloud 15.0.7, Gallery 18.2.0

Updated from an older installation or fresh install: Fresh install

Are you using custom gallery.cnf config files: no

Client configuration

Browser: Firefox 67

Operating system: Windows 10

ravi-gh commented 5 years ago

I believe the related issue of "Hide download" not working when sharing a single image was resolved in the following issue report - #484 However, the above fix does not apply when the shared item happens to be an entire folder with images. Further fixes are required for this.

mstenz commented 4 years ago

thank you for adding this bug, i am experiencing the same. Because this is a security leak please have high priority on this topic. I wanted to use gallery to share images on my website that are hosted on nextcloud but with this situation i am not able yet to make this happen.