nextcloud / groupfolders

๐Ÿ“๐Ÿ‘ฉโ€๐Ÿ‘ฉโ€๐Ÿ‘งโ€๐Ÿ‘ฆ Admin-configured folders shared by everyone in a group. https://github.com/nextcloud-releases/groupfolders
https://apps.nextcloud.com/apps/groupfolders
288 stars 87 forks source link

Trailing spaces in groupfolder child's folder reverts advanced permission settings #1999

Open freumichCH opened 2 years ago

freumichCH commented 2 years ago

Steps to reproduce

  1. Creating a groupfolder and assigned permission to a User or Group of Users
  2. Creating a child folder with multiple trailing spaces in Name. (Possible over drag and drop upload or SyncClient. Not in Web)
  3. Go to advance permission setting pane of created child folder and restrict write access for assigned user.
  4. Refresh page and open again the advanced permission settings pane --> the settings have be reverted.

Expected behaviour

Advanced permission should keep settings, even with spaces in folder name

Actual behaviour

The settings will be reverted.

Server configuration

Nextcloud version: 23.0.4

Group folders version: 11.1.4 (Also testet with 11.1.2 and 11.1.1)

Are you using external storage, if yes which one: no

Are you using encryption: yes/no no

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: Firefox, Safari (latest)

Operating system: macOS 12.5.4 Fedora 36

Logs

Web server error log

Nothing relevant found

Nextcloud log (data/nextcloud.log)

Nothing relevant found

Browser log

Nothing relevant found

a) $ is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own.

How to solve issue

Removing the trailing spaces from the folder name will solve the issue.

Personal opinion

I'm a bit confused about how users create folders. That should really not be done on this way. But we can now see that it is happening. Is there a Way to fix this in the code of the groupfolder app?

Thanks in advance!

freumichCH commented 2 years ago

really no one?

joshtrichards commented 2 months ago

Related: #2990