nextcloud / groupfolders

๐Ÿ“๐Ÿ‘ฉโ€๐Ÿ‘ฉโ€๐Ÿ‘งโ€๐Ÿ‘ฆ Admin-configured folders shared by everyone in a group. https://github.com/nextcloud-releases/groupfolders
https://apps.nextcloud.com/apps/groupfolders
278 stars 85 forks source link

Restoring a file from the trashbin that was deleted from a previously deleted subfolder causes unexpected behaviour #2041

Open jngrb opened 2 years ago

jngrb commented 2 years ago

How to use GitHub

Steps to reproduce

  1. Create a group folder /groupfolder (can have ACL or not)
  2. Create a sub folder /groupfolder/sub
  3. Create a file /groupfolder/sub/to-be-deleted in the sub folder
  4. Delete the file /groupfolder/sub/to-be-deleted
  5. Delete the folder /groupfolder/sub
  6. Restore the file to-be-deleted from the trashbin

Expected behaviour

Restoration either fails because the folder to which the restoration should happen no longer exists. Or restoration re-creates the deleted folder and puts the deleted file in it (but only if the restoring user has the necessary permissions.)

Actual behaviour

The file to-be-deleted is restored in the root groupfolder, i.e. as /groupfolder/to-be-deleted

Extended test 1

Extended test 2

Server configuration

Operating system: Official nextcloud (FPM) container in OKD/Openshift

Web server: Nginx reverse proxy as "side-container" behind OKD/Openshift-Router

Database: Postgresql

PHP version: PHP 8.0.20

Nextcloud version: NC 24.0.2

Group folders version: 12.0.1

Updated from an older Nextcloud/ownCloud or fresh install: upgraded for several versions now

Client configuration

Browser: Firefox (does not matter)

Operating system: Ubuntu (does not matter)

Logs

Web server error log

Web server error log ``` Insert your webserver log here ```

Nextcloud log (data/nextcloud.log)

Nextcloud log ``` ```

Browser log

Browser log ``` Insert your browser log here, this could for example include: a) The javascript console log b) The network log c) ... ```
joshtrichards commented 1 week ago

Related: #2644