search

nextcloud / groupfolders

📁👩‍👩‍👧‍👦 Admin-configured folders shared by everyone in a group. https://github.com/nextcloud-releases/groupfolders
https://apps.nextcloud.com/apps/groupfolders
291 stars 87 forks source link

fix: include mountpoint in original location for trash items #3362

Closed icewind1991 closed 1 month ago

icewind1991 commented 1 month ago

Currently the "original location" for deleted groupfolder items don't show the path of the groupfolder itself. Making it harder for users to know what the deleted file is.

This changes it to store the "full" original location and separately keep the "interal" original location for the restore operation.

icewind1991 commented 1 month ago

/backport to stable30

icewind1991 commented 1 month ago

/backport to stable29

icewind1991 commented 1 month ago

/backport to stable28

provokateurin commented 1 month ago

From https://github.com/nextcloud/groupfolders/issues/3339 we have https://github.com/x7airworker/groupfolders/blob/361d4314f6fa53a1a90735bf4fd42e30fb5d3785/tests/Trash/TrashBackendTest.php#L218 which can produce this error reliably. Can you add it and verify it fixes the test?

icewind1991 commented 1 month ago

This (should) only changes how the path is displayed. So I think it's orthogonal from that issue/test, which I understand to be caused by what path is stored.

provokateurin commented 1 month ago

You're right, I confused this with another issue.