nextcloud / guests

🙈 Create guest users which can only see files shared with them
https://apps.nextcloud.com/apps/guests
GNU Affero General Public License v3.0
46 stars 28 forks source link

[Bug]: Not possible to disable Guest-Allowlist (change doesn't save) #995

Open mamo2021 opened 1 year ago

mamo2021 commented 1 year ago

⚠️ This issue respects the following points: ⚠️

Bug description

In guest-permissions it is possible to set an allowlist for guest-apps.

  1. Error: Deactivating this Option isn't possible (setting isn't saved after changing).

  2. Error: Allowlist-Entrys aren't fully visible and not fully readble

  3. Error: When clicking in the field, the chosen entrys dissapear and a list of values opens, but none of them seems visibly chosen (no checkmarks visible).

  4. Error: The Reset-Button doesn't work.

Guest-App V. 2.3.0 Nextcloud V. 25.0.3 Tried in Google Chrome 110.0.5481.77 64-bit Tried in Firefox 110.6 64-bit

Steps to reproduce

  1. Open the Administrator-Settings
  2. Open the general Guest-Settings
  3. Disable the allow-list-setting, change to anoter menu-point and change back to guest-settings: the allow-list-setting is active again
  4. Try to edit the allow-list (not all entrys are visible, when the textline exceeds the lengh of the field; by opening the dropdown-list the chosen entrys arent marked)
  5. Thy to Rest the allow-list after editing.

Expected behavior

The user should be able to deaktivate the allow-list-setting. The user should be able to read all chosen entrys of the allow-list an all chosen entrys shoud be marked visible in the list. The Reset-Button shoud set the default-settings.

Installation method

Other Community project

Operating system

Other

PHP engine version

PHP 8.1

Web server

Apache (supported)

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 22.2.3 to 22.2.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

Configuration report

No response

List of activated Apps

occ $ app:list
Enabled:  - activity: 2.17.0  - admin_audit: 1.15.0  - analytics: 4.7.1  - bruteforcesettings: 2.5.0  - calendar: 4.2.3  - cfg_share_links: 3.0.2  - circles: 25.0.0  - cloud_federation_api: 1.8.0  - comments: 1.15.0  - contacts: 5.1.0  - contactsinteraction: 1.6.0  - dashboard: 7.5.0  - dav: 1.24.0  - deck: 1.8.3  - drawio: 2.1.0  - event_update_notification: 2.0.0  - federatedfilesharing: 1.15.0  - federation: 1.15.0  - files: 1.20.1  - files_accesscontrol: 1.15.1  - files_antivirus: 4.0.2  - files_automatedtagging: 1.15.0  - files_downloadactivity: 1.15.0  - files_downloadlimit: 1.0.1  - files_external: 1.17.0  - files_linkeditor: 1.1.13  - files_mindmap: 0.0.27  - files_pdfviewer: 2.6.0  - files_retention: 1.14.1  - files_rightclick: 1.4.0  - files_sharing: 1.17.0  - files_trashbin: 1.15.0  - files_versions: 1.18.0  - firstrunwizard: 2.14.0  - forms: 3.0.4  - groupfolders: 13.1.1  - guests: 2.3.0  - logreader: 2.10.0  - lookup_server_connector: 1.13.0  - nextcloud_announcements: 1.14.0  - notes: 4.6.0  - notifications: 2.13.1  - oauth2: 1.13.0  - occweb: 0.1.0  - password_policy: 1.15.0  - passwords: 2023.2.20  - photos: 2.0.1  - polls: 4.1.2  - privacy: 1.9.0  - provisioning_api: 1.15.0  - quota_warning: 1.15.0  - ransomware_protection: 1.14.0  - recommendations: 1.4.0  - related_resources: 1.0.3  - richdocuments: 7.1.0  - serverinfo: 1.15.0  - settings: 1.7.0  - sharebymail: 1.15.0  - spreed: 15.0.3  - support: 1.8.0  - survey_client: 1.13.0  - systemtags: 1.15.0  - tasks: 0.14.5  - terms_of_service: 2.0.1  - text: 3.6.0  - theming: 2.0.1  - twofactor_backupcodes: 1.14.0  - twofactor_email: 2.7.1  - twofactor_nextcloud_notification: 3.5.0  - twofactor_totp: 7.0.0  - updatenotification: 1.15.0  - user_status: 1.5.0  - viewer: 1.9.0  - weather_status: 1.5.0  - workflowengine: 2.7.0Disabled:  - encryption  - flow_notifications: 1.4.0  - socialsharing_email: 2.5.0  - socialsharing_facebook: 2.5.0  - socialsharing_twitter: 2.5.0  - suspicious_login  - user_ldap

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

joshtrichards commented 5 months ago
  1. Confirmed - let's use this issue to track that.
  2. Let's track that in #1124
  3. I'm unable to reproduce this behavior. Can you still reproduce this behavior today? Either way, let's track this in #980
  4. Same. Still seeing this today?
joshtrichards commented 5 months ago

Related: #979