nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.
GNU Affero General Public License v3.0
331 stars 269 forks source link

[Feature] High Performance File Backend #109

Open Blackclaws opened 3 years ago

Blackclaws commented 3 years ago

Are you planning to include the High Performance File Backend aka Client Push in the Helm chart or would you accept a pull request that adds this? This might be related to #106 as Nextcloud 21 is a base requirement for that.

menardorama commented 3 years ago

Already have a working version but I can't find an elegant way to install and setup the app except using a one time job. As of now it seems in my opinion that there is too much manual steps to cover...

sbor23 commented 3 years ago

Sorry for being off-topic.

If you find a way it would be great to expose the feature of specifying a range of apps to install along side. This would help a lot getting towards a true stateless setup.

Blackclaws commented 3 years ago

Using a one time job is fine for setup things like this. A lot of other helm charts do that such as the gitlab chart

menardorama commented 3 years ago

Yes you're right that seems possible

chrisingenhaag commented 3 years ago

I think it would be more nice to have a docker image of the notify_push serverside component instead of "installing" it within Pod start. I would prevent this if I can.

Blackclaws commented 3 years ago

I guess having a separate docker image would also work, the concept of installing it into the server and simply mounting the same apps volume into notify push also works rather well however, that way you are also always in sync between the app and the service.

jessebot commented 1 year ago

I'm happy to review any pull request, but what exactly is the current plan here?

We are on Nextcloud 25 now, so this issue may be stale, but I'm happy to discuss regardless :)

provokateurin commented 1 year ago

I found this issue because I was checking if notify_push is supported. @jessebot I think we should try making more Nextcloud components ready to use. I think that would include the HPBs for Files and Talk, notify_push and the Talk recording server (and maybe more). I don't know how hard each of these are, but it would be nice to support them.

jessebot commented 11 months ago

Sorry for the extreme delay. Sometime in June I accidentally cleared all my github notifications and I'm still wading through old issues and PRs trying to figure out what I missed 🤦

I think that would include the HPBs for Files and Talk, notify_push and the Talk recording server (and maybe more).

HPB is high performance backend, right? As in the backends listed in this blog post?

how do you feel about a nextcloud.objectStore section like mentioned in https://github.com/nextcloud/helm/issues/477#issue-2000830792?

Then we could have like:

nextcloud:
  objectStore:
    s3:
      enabled: true
    swift:
      enabled: false
Nils98Ar commented 11 months ago

I found this issue because I was checking if notify_push is supported. @jessebot I think we should try making more Nextcloud components ready to use. I think that would include the HPBs for Files and Talk, notify_push and the Talk recording server (and maybe more). I don't know how hard each of these are, but it would be nice to support them.

Maybe some should be separate charts?

The templates from https://github.com/nextcloud/all-in-one/tree/main/nextcloud-aio-helm-chart/templates could probably be used as basis …

AndreKoepke commented 7 months ago

This would be cool. It seems to me, that for the following things are required:

Can we preconfigure that into the chart so that it will be the default?