poggenpower commented 10 months ago

Pull Request

Description of the change

is netxcloud.containerport is set, it will also configure the port for nginx. This allows nginx running in a rootless container e.g. by using their official nginxinc/nginx-unprivileged image. pid is written to /tmp for that reason. Some enhanced configs parameter for service.

Benefits

rootless nginx conaiiner.

Possible drawbacks

the nginx port will switch to netxcloud.containerport in FPM installations, but this should be

very rare, because netxcloud.containerport should not be changed
even if changed the service will automatically connect to the changed port.

Applicable issues

N/A

Additional information

Checklist

[X] DCO has been signed off on the commit.
[X] Chart version bumped in Chart.yaml according to semver.
[x ] (optional) Variables are documented in the README.md

jessebot commented 10 months ago

@poggenpower sorry, it says there's a conflict even though there's not. Can you fix the conflict? I don't want to update your main branch unless you're ok with that.