nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.
GNU Affero General Public License v3.0
325 stars 264 forks source link

updating postgres-is-ready init container to use the same hostname env var template as the nextcloud container #442

Closed jessebot closed 1 year ago

jessebot commented 1 year ago

Pull Request

Description of the change

This changes the template for the postgresql-is-ready init container to use the same hostname variable, POSTGRES_HOST that we use for the actual nextcloud container.

Benefits

This should make it so that if you use postgresql.enabled=true and postgresql.fullnameOverride=my-postgres-name that we use that for checking if postgresql is ready as well. Previously, we were using {.Release.name}-postgresql which would not accommodate postgresql.fullnameOverride.

Possible drawbacks

None that I can think of, but as always, open to feedback. If there's a better hostname to use instead of the primary hostname, I'm happy to change to that though I only saw a few services in the bitnami postgresql templates and those were the primary, primary headless, and read replicas. Read could work, but I actually don't know what primary headless does?

Checklist

jessebot commented 1 year ago

I will merge this after #444 so just before that, I'll update the chart version one last time.