search

nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.
GNU Affero General Public License v3.0
325 stars 264 forks source link

postgresql image tags not iso for pods "postgresql-isready" and "postgresql" #468

Closed schmittvictor closed 9 months ago

schmittvictor commented 10 months ago

Describe your Issue

I needed to change de registry of the postgresql image and noticed a bug:

Example: 

postgresql:
  enabled: true
  image:
    debug: false
    digest: ''
    pullPolicy: IfNotPresent
    pullSecrets: null
    registry: docker-repo.domain.com:18440
    repository: bitnami/postgresql
    tag: 15.4.0-debian-11-r10

The image full url that will be used for the pod "postgresql-isready" is wrong and the image used for the pod "postgres" will be "docker-repo.domain.com:18440/bitnami/postgresql:15.4.0-debian-11-r10" (as expected).

Describe your Environment

jessebot commented 10 months ago

if you'd like to use a registry, we'd happily accept a PR for that. We have one here, https://github.com/nextcloud/helm/pull/262, but it hasn't been updated in a year, so you can submit a new one, provided you also please update the values.yaml, README, and bump the version in Chart.yaml. Update: We now have a CONTRIBUTING.md for reference :)