Closed ishioni closed 10 months ago
+1 - this break was introduced in this PR here: https://github.com/nextcloud/helm/pull/465
I also added a comment on that PR to expand upon the issue being seen
+1 same issue here, rolling back to 4.5.0
looking! Apologies for the inconvenience!
Update: looks like we have a potential fix in #465.
Update again: I marked the current release as a pre-release, meaning not ready for production, and linked to both this bug and the PR that is in the works to fix it :pray:
Hello, as I think my issue is related I decided not to open another one. I noticed that the extraVolumes were broken in 4.5.1:
I was getting the following error when trying to upgrade:
YAML parse error on nextcloud/templates/deployment.yaml: error converting YAML to JSON: yaml: line 192: did not find expected key
I did a little digging and what I found is that the nindent in the deployment template for the extraVolumes was wrong. It is currently:
{{- with .Values.nextcloud.extraVolumes }}
{{- toYaml . | nindent 6 }}
{{- end }}
when I change it to "8" the template renders without any issues. Hope you can fix this as well with the above PR. Thanks!
good hint @djbobyd i but it also into #476
(PS: @ishioni Nice bot which makes an helm diff in context of fluxcd - what bot software do you use for it?)
This was meant for the PR with the fix
Hmm, I'm trying to test but seeing an odd error during chart rendering (shown below). I don't think this is tied to your change. Seeing if I can figure out what it is
Error: template: test/charts/postgresql/templates/primary/svc.yaml:11:14: executing "test/charts/postgresql/templates/primary/svc.yaml" at <include "common.labels.standard" (dict "customLabels" .Values.commonLabels "context" $)>: error calling include: template: test/charts/mariadb/charts/common/templates/_labels.tpl:11:27: executing "common.labels.standard" at <include "common.names.name" .>: error calling include: template: test/charts/mariadb/charts/common/templates/_names.tpl:11:18: executing "common.names.name" at <.Chart.Name>: nil pointer evaluating interface {}.Name helm.go:84: [debug] template: test/charts/postgresql/templates/primary/svc.yaml:11:14: executing "test/charts/postgresql/templates/primary/svc.yaml" at <include "common.labels.standard" (dict "customLabels" .Values.commonLabels "context" $)>: error calling include: template: test/charts/mariadb/charts/common/templates/_labels.tpl:11:27: executing "common.labels.standard" at <include "common.names.name" .>: error calling include: template: test/charts/mariadb/charts/common/templates/_names.tpl:11:18: executing "common.names.name" at <.Chart.Name>: nil pointer evaluating interface {}.Name
Thank you, @wrenix for tending to this!
A new release, 4.5.2
, should be out since this job completed. We tested it in the pipeline and I tested it on my VPS via Argo CD before pushing it up.
@ishioni , @DanishVaid , @djbobyd , @nafets227 can you all please let me know if your errors are resolved after testing the latest release?
Thanks everyone for their patience and kind vibes :blue_heart:
edit: the release job hadn't finished yet, so I had to link to it :facepalm:
Job's finished but the chart doesn't seem to available yet :/
Job 81 needs to finish before we can see the new chart version in the helm repo (it's pushing the content from gh-pages branch to the GitHub pages).
I´m waiting for it, too, to start testing
@nafets227 great catch! Forgot that it takes a bit because I think the nextcloud org is low on GHA minutes and they're still implementing self hosted runners. Sorry about that, @ishioni :pray:
ok, that job has completed and after:
helm repo update
helm show chart nextcloud/nextcloud
I finally get:
apiVersion: v2
appVersion: 27.1.3
dependencies:
- condition: postgresql.enabled
name: postgresql
repository: oci://registry-1.docker.io/bitnamicharts
version: 12.12.*
- condition: mariadb.enabled
name: mariadb
repository: oci://registry-1.docker.io/bitnamicharts
version: 12.2.*
- condition: redis.enabled
name: redis
repository: oci://registry-1.docker.io/bitnamicharts
version: 17.13.*
description: A file sharing server that puts the control and security of your own
data back into your hands.
home: https://nextcloud.com/
icon: https://cdn.rawgit.com/docker-library/docs/defa5ffc7123177acd60ddef6e16bddf694cc35f/nextcloud/logo.svg
keywords:
- nextcloud
- storage
- http
- web
- php
maintainers:
- email: skjnldsv@protonmail.com
name: skjnldsv
- email: christian.ingenhaag@googlemail.com
name: chrisingenhaag
- email: jeff@billimek.com
name: billimek
name: nextcloud
sources:
- https://github.com/nextcloud/helm
- https://github.com/nextcloud/docker
version: 4.5.2
same here:
[root@phys1Ci ~]helm search repo nextcloud
NAME CHART VERSION APP VERSION DESCRIPTION
nextcloud/nextcloud 4.5.2 27.1.3 A file sharing server that puts the control and...
CI Tests are running ...
works here :)
So finally I can confirm that chart version 4.5.2 solves the issue introduced with 4.5.1 for me.
thanks @jessebot @wrenix for quick fix. And thanks to you and all the next cloud team for the great product and helm chart!
Confirm on my end too
Describe your Issue
Chart version 4.5.1 replaced indent with nindent for config files. This unfortunately ends up rendering those config files with a newline prepended
Logs and Errors
As you can see in my local flux repo PR, extra config files are now rendered with a newline and a |2- instead of a |-, and an added newline as a bonus. This in turns errors out nextcloud with an error
Describe your Environment
Kubernetes distribution: talos v1.5.5
Helm Version (or App that manages helm): flux v2.1.2
Helm Chart Version: 4.5.1
values.yaml
:Additional context, if any