search

nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.
GNU Affero General Public License v3.0
325 stars 264 forks source link

fix: another cleanup and linting (contains move to configfiles) #478

Closed wrenix closed 10 months ago

wrenix commented 10 months ago

few parts cleanup and lint

contains commit of:

Checklist

jessebot commented 10 months ago

This is too big of a commit to be a patch change. This should be a minor or major change, but I think it might be best to avoid these massive PRs in the future, as they're hard to review. People use this helm chart for important personal and professional aims, and we should try to make PRs as clear and concise as possible, to help others debug any potential bugs that may arise. Please instead target specific and small changes.

wrenix commented 10 months ago

I understand your position, for the future i will make it - i has already said in my PSS, that i will create smaller PRs.

So what should i do with this PR now. change the semver level or splitt it up in multiple commits or multiple PRs?

jessebot commented 10 months ago

Let's do specific small PRs and close this one for now. We still need to test and fix the bug from the other day before doing more clean up though as the chart is currently broken on the latest version. Thank you for understanding

jessebot commented 10 months ago

I am going to close this in favor of #480 and #481

wrenix commented 10 months ago

here are still two commits, with another cleanup

jessebot commented 10 months ago

If there are still two smaller commits left on this repo, could you please isolate them and explain what they do in the PR description, and then I can reopen this, or you can option a new PR, up to you.