nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.
GNU Affero General Public License v3.0
296 stars 258 forks source link

Update CONTRIBUTING.md - add testing tips and screenshot for allow edits by maintainers #479

Closed jessebot closed 6 months ago

jessebot commented 7 months ago

Pull Request

Description of the change

This add some more items to the contributing docs to check before submitting a PR, and it now briefly goes over testing the changes locally.

Benefits

Users can learn about helm lint, helm template, and the ct (chart testing) command. These are all tools by the helm project itself.

Possible drawbacks

more to read :P

Applicable issues

n/a

Additional information

n/a

Checklist

jessebot commented 7 months ago

We should probably also add how to make a PR editable by maintainers, so that we can bump helm chart versions and resolve (minor) conflicts if necessary. :thinking:

jessebot commented 6 months ago

I've updated the docs to include a screenshot of how to allow edits by maintainers. @provokateurin or @tvories could you please review? Thank you :pray:

jessebot commented 6 months ago

thank you!