nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.

GNU Affero General Public License v3.0

295 stars 258 forks source link

feat(docs): Document service discovery with nginx and ingress #491

Closed provokateurin closed 7 months ago

provokateurin commented 7 months ago

Pull Request

Description of the change

Documents how to get the service discovery working in case of using nginx and ingress.

Benefits

People (including me) struggled with the service discovery because it was not documented how to get it working. The server snippet was already in the values, but it was nowhere mentioned that it is needed.

Possible drawbacks

None, only more documentation.

Applicable issues

Fixes https://github.com/nextcloud/helm/issues/410

Additional information

@qlonik @adborden Please test if this solves your problems (I couldn't directly request a review from you).

Checklist

[x] DCO has been signed off on the commit.
[ ] Chart version bumped in Chart.yaml according to semver.
[ ] (optional) Variables are documented in the README.md

jessebot commented 7 months ago

People (including me) struggled

That's so real haha shared nextcloud community experience getting this php app working in the cloud :D

For the actual content of this PR: 🤔 I haven't tried this yet, but this does seem to follow what I was trying once upon a time here: https://github.com/nextcloud/helm/issues/410#issuecomment-1631157214

I will assume it works based on your findings in #410 but can we please hold off on closing that issue till I get a chance to test this as well?

provokateurin commented 7 months ago

Oh interesting I forgot that you tried this. Maybe you had the same caching issues as I had. We can totally leave this issue open for you to test. My instance is fixed now and that's all I care about right now :sweat_smile:

jessebot commented 7 months ago

Oh interesting I forgot that you tried this. Maybe you had the same caching issues as I had.

Yeah, I'm hoping it's cache or the cors issue was biting me 😅, but I've been battle testing the s3 object storage backend, and more recently getting rid of the nginx container, for weeks and haven't had the chance to look into this issue again. Team work though! We're gonna make it work!

Also approved this. You can merge when you're ready :)