nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.
GNU Affero General Public License v3.0
295 stars 258 forks source link

feat: add support for immutable image #496

Open thefirstofthe300 opened 6 months ago

thefirstofthe300 commented 6 months ago

Pull Request

Description of the change

Nextcloud is capable of being built using an immutable image (see https://github.com/thefirstofthe300/nextcloud-docker). In this scenario, there is no point in mounting the /var/www and /var/www/html directories to store state. The remaining directories should be mounted, but not these two.

Benefits

Allows users to build their own immutable images which do not perform an rsync on start but still use this chart.

Possible drawbacks

The default values are not changing so I see no drawbacks.

Additional information

jessebot commented 2 months ago

Does anything bad happen if those volumes are mounted anyway? It looks like you linked a custom image, which you can absolutely use, but I'm unsure if we support this. Either way, the branch needs to be rebased.

@provokateurin are you aware of an immutable mode for nextcloud? I don't really see any issues with merging this, but I also don't have a quick way to test it.

provokateurin commented 2 months ago

Nextcloud is not really immutable. It will probably run into quite a few issues because all code assumes the whole dir is writable.