search

nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.
GNU Affero General Public License v3.0
336 stars 268 forks source link

chore: move metrics yaml to extra folder #516

Closed wrenix closed 10 months ago

wrenix commented 10 months ago

a first / last try of a really easy reviewable PR

if you see this and need more then 5min ....

@provokateurin

a split of #481 which is an split of #478 (which does not contain any changes in logic and is 2,5 month old)

provokateurin commented 10 months ago

I understand you are frustrated, but please stay friendly towards others https://nextcloud.com/contribute/code-of-conduct/

provokateurin commented 10 months ago

Honestly I'm not sure if this change makes sense. According to https://helm.sh/docs/chart_best_practices/templates/ the current structure is best practice and the page doesn't mention that subdirectories are allowed (but it also doesn't say they are not allowed). https://stackoverflow.com/a/77619725 suggests that it still works, even if it is not documented.

wrenix commented 10 months ago

your first link is good, but it does not say anything about, if much of my-example exists and nothing about folders inside of templates.

your stackoverflow post, say - that it works (and yes it works also for application charts).

wrenix commented 10 months ago

that change does not change any logic -> semver a chore, which does not need a new version, but maybe your ci failed ...

provokateurin commented 10 months ago

CI is still running, I'm not sure if it will require a new version :thinking:

wrenix commented 10 months ago

it needs: https://github.com/nextcloud/helm/actions/runs/7754331260/job/21148125372?pr=516 therefore an change.