nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.

GNU Affero General Public License v3.0

295 stars 258 forks source link

easy readible indent #517

Closed wrenix closed 5 months ago

wrenix commented 5 months ago

Pull Request

array with:

array:
  - 3

instatt of

array:
- 3

this is just of templating part {{- will remove all spaces before that, so moved to level of yaml structure.

(i change of {{ to {{- will happen in another PR with the replace of if to when).

draft, i am waiting for the merge of #516

provokateurin commented 5 months ago

Do you know if there is a tool that could automatically enforce these style rules? I think your suggested changes are very good, I just want to ensure that they will stay that way and that other places can be safely refactored as well.

wrenix commented 5 months ago

At the moment, i do not know any tools - i will take a look into the chart-testing you already use (it use in background the yamllint tool written in python)

provokateurin commented 5 months ago

Shall we merge this already or wait for a potential tool that could enforce the style?

wrenix commented 5 months ago

i like to create the next PR ... in the end, i want also add some chart-testing values-files as best practics ... maybe we discuss it there.

e.g.: https://github.com/nextcloud/helm/pull/480/commits/a6ca7bd23c7bcaa59816edee69b1156a8fc001ec