nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.

GNU Affero General Public License v3.0

295 stars 258 forks source link

chore: replace if with with (and improve strip using with -) #518

Closed wrenix closed 4 months ago

wrenix commented 5 months ago

Pull Request

Checklist

[x] DCO has been signed off on the commit.
[x] Chart version bumped in Chart.yaml according to semver.
[ ] (optional) Variables are documented in the README.md

wrenix commented 5 months ago

I am a hours away from keyboard, sry -> i believe there is needed, but i take a look

wrenix commented 4 months ago

you are correct, if i would not use in some places {{- toYaml, i could use indent instatt of nindent. I often use it together with {{- with and {{- end`. so it looks for me nice on writing and reading.

that is a kind of personal preference. should i change it?

provokateurin commented 4 months ago

I see, that makes sense. Then I prefer this style :) Still, it would be great to have a tool to enforce the style.

wrenix commented 4 months ago

increase chart-version after rebase