nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.
GNU Affero General Public License v3.0
295 stars 258 forks source link

Feature: Add persistence settings for redis #546

Open f3k-freek opened 3 months ago

f3k-freek commented 3 months ago

Description of the change

Add persistence settings for the redis database. Such as storageClass and wether it should be enabled at all.

Benefits

Possible drawbacks

jessebot commented 3 months ago

Thanks for submitting a feature request :)

You can use any persistence settings you find the bitnami docs here: https://github.com/bitnami/charts/tree/main/bitnami/redis

The way the helm chart works, the bitnami redis helm chart is a subchart, so we pass through anything under the redis parameter in the values.yaml through to that chart. If you'd like, you can submit a PR to add those settings to our values.yaml just so that people are aware of them. If you do, please remember to bump the chart version and update the README in the charts/nextcloud directory, so that everyone can benefit.

f3k-freek commented 2 months ago

Thank you for your fast reply. I have submitted a PR as you proposed: https://github.com/nextcloud/helm/pull/549