nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.
GNU Affero General Public License v3.0
295 stars 258 forks source link

feat: keep PVCs when uninstalling helm chart #555

Closed Leptopoda closed 2 months ago

Leptopoda commented 2 months ago

Pull Request

Description of the change

Keep nextcloud PVCs when uninstalling the helm chart

Benefits

Most helm charts keep PVCs on uninstall. The current nextcloud approach is unexpected and thus may lead to data loss. Learned that the hard way :sweat_smile:

Possible drawbacks

None that I'm aware of.

Applicable issues

Additional information

Checklist

provokateurin commented 2 months ago

Duplicate of https://github.com/nextcloud/helm/pull/473

provokateurin commented 2 months ago

Ok let's go with this PR because the other PR is stale...