nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.

GNU Affero General Public License v3.0

295 stars 258 forks source link

Update _helpers.tpl #572

Open bastikus opened 1 month ago

bastikus commented 1 month ago

Returned default values for the external database

Pull Request

Description of the change

Helm chart does not work when using an external database for NextCloud. "key" is not defined.

Checklist

[ ] DCO has been signed off on the commit.
[ ] Chart version bumped in Chart.yaml according to semver.
[ ] (optional) Variables are documented in the README.md

provokateurin commented 1 month ago

This seems wrong, you should simply specify the key values as they are mandatory and defaults are not going to work either because every setup is different.

bastikus commented 1 month ago

This seems wrong, you should simply specify the key values as they are mandatory and defaults are not going to work either because every setup is different.

Default values are indeed defined in values.yaml for external database, but secret for external database is not created in db-secret.yaml, nor are these values used in any other manifests.

provokateurin commented 1 month ago

Hm I think having default values in the values.yaml for those fields makes no sense because everyone has to override them anyway. @jessebot what do you think?