jessebot commented 3 weeks ago

⚠️ Major updates to sub charts

Description of the change

Updates postgresql chart from 12.12.10 to 15.5.0
Updates mariadb chart from 12.2.9 to 18.2.0
Updates redis chart from 17.13.* to 19.5.0
Adds a new job to test postgresql installs

As always, you need to check the official upgrade instructions from both bitnami and the upstream providers. Please see the following docs before attempting the nextcloud helm chart upgrade:

Benefits

We were pretty out of date on all our subcharts, and this also grants us an end to end test with postgresql, which we've been missing for a while.

Possible drawbacks

I don't have a test for mysql, only because I don't actually use mariadb, and don't have the time to create one right now, but if others want to submit that test, I'd be open to testing it locally :)
users will need to still follow the major upgrade docs listed above before they can upgrade, as is the case for all major upgrades of redis, mariadb, and postgresql
I have hardcoded a password for the testing of postgresql. We can easily update this to be a repo secret and then no password will be logged, but that requires someone with better access than myself to add that repo secret, and then tell me know what the name of it is, so I can update the ct command.

Applicable issues

I feel like we had an issue for postgresql testing, but I can't find it right now 🤔

Additional information

You can see an example of the new testing workflow here where I ran it on my personal repo for this feature branch: https://github.com/jessebot/nextcloud-helm/actions/runs/9347132143

Screenshot of the summary section for the jessebot/nextcloud-helm feature branch workflow showing 4 jobs. The first job is the changes job, which then feeds into the linting job, which then triggers both the internal-database test and postgresql-database test. All 4 show as green, meaning success.

In the future, renovateBot will take care of these updates for us, and then we just need to review them. I'm doing this manually now, because we're so very behind.

Checklist

[x] DCO has been signed off on the commit.
[x] Chart version bumped in Chart.yaml according to semver.
[x] (optional) Variables are documented in the README.md

jessebot commented 3 weeks ago

perhaps it also makes sense to update the requires to be the new testing actions? (instead of lint-test, updating it to be test-internal-database)

provokateurin commented 2 weeks ago

Ah yeah now the required workflows are messing this up again. Since everyone has to rebase anyway due to the chart version conflicts it's fine to just set the new jobs to be required.