nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.
GNU Affero General Public License v3.0
334 stars 269 forks source link

fix #508 by checking for `.Values.nextcloud.existingSecret.tokenKey` #601

Closed jessebot closed 3 months ago

jessebot commented 4 months ago

Description of the change

Fix setting NEXTCLOUD_AUTH_TOKEN env var for metrics deployment by ensuring we check for .Values.nextcloud.existingSecret.tokenKey. Also sets .Values.nextcloud.existingSecret.tokenKey to default to '' which shouldn't be a breaking change, considering it was broken before.

Benefits

Now users can actually use the nextcloud.existingSecret.tokenKey feature.

Possible drawbacks

users will need to remember to set nextcloud.existingSecret.tokenKey

Applicable issues

Additional information

Fix originally described here: https://github.com/nextcloud/helm/issues/508#issuecomment-2249855493

Checklist