nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.
GNU Affero General Public License v3.0
334 stars 269 forks source link

Update upgrade notes in `CONTRIBUTING.md`, `README.md`, `values.yaml` #602

Open jessebot opened 4 months ago

jessebot commented 4 months ago

Description of the change

Adds a section about upgrades to clarify we should only do one major version at a time.

Benefits

just a little doc change to prevent gotchya :)

Possible drawbacks

open to feedback but I think this is minor enough that it's fine.

Applicable issues

Additional information

Checklist

jessebot commented 4 months ago

I could improve this PR by also making a note in the values.yaml for the image.tag parameter as mentioned in https://github.com/nextcloud/helm/issues/103 if you agree that's a good idea?

provokateurin commented 4 months ago

I could improve this PR by also making a note in the values.yaml for the image.tag parameter as mentioned in https://github.com/nextcloud/helm/issues/103 if you agree that's a good idea?

Yeah that would be nice too, just to prevent people ending up in broken states...

jessebot commented 3 months ago

Wait, the docs are confusing, due to grammar:

Before you can upgrade to the next major release, Nextcloud upgrades to the latest point release.

If it's what you're saying here:

Upgrading to the latest minor version before upgrading to the next major version should probably also be documented

Then shouldn't it be this?:

Before you can upgrade to the next major release, you need to upgrade to the latest minor for your current major version.

If I can find the repo I need to change this in, I can go update that grammar 🤷

Happy to document that here as well though :)

provokateurin commented 3 months ago

Yes that sounds wrong indeed, you can fix it in https://github.com/nextcloud/documentation

jessebot commented 3 months ago

PR here :) https://github.com/nextcloud/documentation/pull/12062