feat(nextcloud): add support of imaginary an externalPreviewProvider

nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.

GNU Affero General Public License v3.0

334 stars 269 forks source link

feat(nextcloud): add support of imaginary an externalPreviewProvider #622

Open wrenix opened 3 months ago

wrenix commented 3 months ago

Description of the change

Benefits

faster image rendering for preview
nextcloud container is not killed (e.g. OOM) if big and much preview images are generated

Possible drawbacks

Works for me.

TODO:

[x] write CI test

Checklist

[x] I have read the CONTRIBUTING.md doc.
[x] DCO has been signed off on the commit.
[x] Chart version bumped in Chart.yaml according to semver.
[x] (optional) Parameters are documented in the README.md

wrenix commented 2 months ago

ping @jessebot / @provokateurin do you like to review?

provokateurin commented 2 months ago

Sorry, I don't have the time for that atm. I hope I can do it at some point, but only at the beginning of next month the earliest.

jessebot commented 2 months ago

oh this is neat! May I ask what the difference between this and the preview generator app are? (I'm not against it btw, just want to learn more) I will review this more thoroughly as soon as I have a moment 🙏

SIMULATAN commented 1 month ago

Thank you for working on this :rocket: Just wanted to point out that, with Nextcloud 30, the OC\Preview\Imaginary provider no longer generates PDF previews. It may be worth considering adding the new ImaginaryPDF provider to the Imaginary notes in the README.md file. See https://docs.nextcloud.com/server/latest/admin_manual/release_notes/upgrade_to_30.html#previews-for-pdf-files-with-imaginary Thanks again, looking forward to using it to speed up my (terribly slow) Nextcloud media previewing :heart:

wrenix commented 1 month ago

rebased on main and add docu in e393d908f51d040ae6040d32136a3f530614caa3 like @SIMULATAN suggested

wrenix commented 1 month ago

rebased, squashed und test added

wrenix commented 1 month ago

rebased - Does i interprate you @jessebot last comment correct, that i could merge it?

provokateurin commented 4 weeks ago

It would be nice to add a test that generating the preview works (similar to how we test S3 in the job).

wrenix commented 4 weeks ago

Yes, it would be nice - i do not know when a preview generation is triggered (i believe in viewing)

provokateurin commented 4 weeks ago

You can request a preview via https://github.com/nextcloud/server/blob/b5ac989ecd4e6f380af4699cb8c0aae872284459/core/openapi.json#L8178

wrenix commented 32 minutes ago

I found the bug, in the container (why setup of test does not run) ....

So here are the test online.