Feature: Add Collabora as a subchart #611

kriegalex commented 3 months ago

Description of the change

Add a dependency to the 1.1.20 collabora chart from their official repository
Add the subchart config to values.yaml
Add the configuration options documentation to README

Benefits

Install collabora as a subchart of nextcloud via helm

Possible drawbacks

People may try to enable it without knowing what is is and how to configure it (mainly extra_params, server_name, aliasgroups and annotations.

Applicable issues

fixes #611

Additional information

Tested on my local kubernetes cluster with a HTTPS nginx ingress. Nextcloud can communicate with Collabora. Not tested with HAProxy (though it is only a change in annotations specific to HAProxy).

Checklist

[X] I have read the CONTRIBUTING.md doc.
[X] DCO has been signed off on the commit.
[X] Chart version bumped in Chart.yaml according to semver.
[X] Parameters are documented in the README.md

jessebot commented 2 months ago

Oh, awesome! Thanks, @kriegalex for this PR!

Right now the workflow is failing: https://github.com/nextcloud/helm/actions/runs/10956242340/job/30421859233?pr=623#step:7:16

You can fix this by adding the helm repo for collabora to this section of the workflow file, similar to how we do for bitnami: https://github.com/nextcloud/helm/blob/b25b4ad50bb46bb61947f9c35260f681d4706885/.github/workflows/lint-test.yaml#L39-L41

kriegalex commented 1 month ago

Thanks for the change on lint tests. I'm still learning k8s, didn't think of that.

nextcloud / helm