fix s3 `secretKeys.sse_c_key` secret key checking typo; now `sse_c_key` is not required for using s3 with this chart - Githubissues

nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.

GNU Affero General Public License v3.0

334 stars 269 forks source link

fix s3 `secretKeys.sse_c_key` secret key checking typo; now `sse_c_key` is not required for using s3 with this chart #631

Closed jessebot closed 2 months ago

jessebot commented 2 months ago

Description of the change

I did a copypasta typo where I was checking for the s3 bucket parameter instead of the sse c key parameter 🤦 This PR fixes that.

Benefits

Now SSE C won't be required to use this chart with s3 as a primary object store.

Possible drawbacks

none that come to mind, but happy to chat :)

Applicable issues

fixes #616

Checklist

[x] I have read the CONTRIBUTING.md doc.
[x] DCO has been signed off on the commit.
[x] Chart version bumped in Chart.yaml according to semver.
[x] (optional) Parameters are documented in the README.md