search

nextcloud / helm

A community maintained helm chart for deploying Nextcloud on Kubernetes.
GNU Affero General Public License v3.0
334 stars 269 forks source link

chore: upgrade postgresql to 17.0 (chart 16.2.0) #642

Open GreyXor opened 1 month ago

GreyXor commented 1 month ago

Description of the change

Update postgresql to 17.0 (chart version is 16.0) close #641

Benefits

provokateurin commented 1 month ago

Thanks, the version number of the Chart needs to be bumped as well. @jessebot @wrenix does this justify bumping the major version or would the minor version be enough?

GreyXor commented 1 month ago

Thanks, the version number of the Chart needs to be bumped as well. @jessebot @wrenix does this justify bumping the major version or would the minor version be enough?

Thanks, I'll update it when we know which version we need here :+1:

wrenix commented 1 month ago

I have to take a look in the bitmani chart (if it make some migrates). If not, i will bump a major version (like the bitmani chart too) and write a Changelog / Migration step.

PS: Private i wrote my own postgresql chart and use there the pgautoupgrade as init container (with PGAUTO_ONESHOT=yes) ...

wrenix commented 1 month ago

PS: Current PostgreSQL is not supported by Nextcloud (a Warnung appears): nextcloud/server#48495

provokateurin commented 1 month ago

So better not merge it yet until any Nextcloud version officially supports it. It might just be alright, but better safe than sorry.

jessebot commented 1 month ago

Hoi! Yes, it should be a major update to the chart, as otherwise, it will attempt to upgrade a major version of the database if a user is using the bundled postgresql with this chart. I actually didn't know postgresql was supported by nextcloud at all :O Agree, if it is supported we should wait on this merge.

GreyXor commented 1 week ago

Nextcloud now officially support postgresql 17: https://github.com/nextcloud/server/pull/49240 @provokateurin @wrenix Thanks 👋

provokateurin commented 1 week ago

That will only be in Nextcloud 31, so still not ready.

GreyXor commented 1 week ago

That will only be in Nextcloud 31, so still not ready.

In the meantime, waiting for 31. Does this PR seem ready to be merged? Or are there things to add/modify?

wrenix commented 1 week ago

nice do You like to make it merge ready? Maybe https://github.com/nextcloud/server/commit/dea6bd73620b2a033f59b506b1c5f1466d37dd54 would be in v30.0.3 ;)

Like to sign-of your commits (DCO check)

provokateurin commented 1 week ago

would be in v30.0.3

No it won't, it is not on the stable30 branch which means it will be only in Nextcloud 31.

provokateurin commented 6 days ago

Can we please keep it as a draft until we have Nextcloud 31 support in the chart?