search

nextcloud / integration_collaboard

Collaboard integration in Nextcloud
https://apps.nextcloud.com/apps/integration_collaboard
GNU Affero General Public License v3.0
6 stars 0 forks source link

Change login flow, use public api endpoints, support on-premises instances #19

Closed MB-Finski closed 8 months ago

MB-Finski commented 8 months ago

Changes the UI login flow to better match that of the Collaboard website. Also, provides a fix for the breaking change in the upstream authentication logic.

P.S. Just realized looking at the change highlights that the collaboardApiService->login() method is a bit "heavy" and could maybe benefit from some refactoring, wdyt?

MB-Finski commented 8 months ago

@julien-nc Both prs are now consolidated under this pr. Did a quick test and login and basic functionalities work now so you should be able to test the private instance.

MB-Finski commented 8 months ago

@julien-nc It should be, functionality-wise, pretty much done now and ready for a review..

github-actions[bot] commented 8 months ago

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!