Refactor

[vitormattos]

Hi @eneiluj , I'm reviewing your app's code. I want to improve performance and parallelize the download of Dropbox files.

Is it okay for you to send separate pull requests to make it easier to review the code?

In this pull request I removed an unused property and added the service property to improve coding in an IDE.

[julien-nc]

Hi @vitormattos,

As long as the changes don't mix multiple different things/topics, you can make big PRs, i don't mind. Do you want to add stuff to this PR or can I merge it right now?

[julien-nc]

And by the way, as Dropbox most likely sends faster than everybody can receive, I don't feel it's necessary to parallelize file download as you're still going to get stuck at your connection max speed.

[vitormattos]

For now nothing to add to it.

Because the app is without unit tests, I'm doing manual tests. I think it's safer to go for smaller parts so as not to get too complex when doing the review.

[vitormattos]

I need to transfer more than 600 GB from Dropbox to the Nextcloud and for some reason the job is dying without logs after about 60 GB transferred.

Importing files has other processes besides downloading, for example IO. When the import is done in a queue and for many files, the time increases.

The goal is to parallel a poll of up to 5 requests so that, while a download is being made, a response promise from another download is being processed.

[vitormattos]

Just in time, I can put this pull request as a draft and add everything to it. Finally, you do one last review. Do you prefer it this way?

Now that I recognize you, hi @eneiluj !!!

[vitormattos]

Hi @eneiluj , I made some refactors and I'm testing with the import of 600Gb, it is without problems. I suggest you do the code review by the sequence of commits.

[julien-nc]

You forgot to import OCP\Files\ForbiddenException :wink:.

[vitormattos]

@eneiluj done.