search

nextcloud / integration_gitlab

🦊 GitLab integration into Nextcloud
https://apps.nextcloud.com/apps/integration_gitlab
GNU Affero General Public License v3.0
42 stars 8 forks source link

feat: Support multiple accounts #93

Closed provokateurin closed 1 month ago

provokateurin commented 2 months ago

Closes https://github.com/nextcloud/integration_gitlab/issues/10

This is quite a massive refactor and I don't think reading through the diff is useful. I also fixed quite a lot of problems I found along the way (e.g. reference resolving without an account was calling apis that are only accessible with an account). I had to drop some things as they are only added complexity (e.g. oauth login from dashboard and popup) and would have made things even more complicated. I'm sorry to drop such a big PR, but splitting it into multiple (except for https://github.com/nextcloud/integration_gitlab/pull/89) was simply not possible.

KaeTuuN commented 1 month ago

I don't know how many differences there are between the Gitlab and Github Integration, but could you also take a look at https://github.com/nextcloud/integration_github/issues/87 @provokateurin ? That would be awesome!