search

nextcloud / integration_mattermost

Mattermost integration in Nextcloud
GNU Affero General Public License v3.0
19 stars 6 forks source link

Adding comment to document creates two posts #11

Closed joho1968 closed 2 years ago

joho1968 commented 2 years ago

Excellent integration! :metal:

If I choose to add a comment to the file I upload (not sharing link), the integration generates two posts. IMHO, it should generate one post with the text (comment) and an attachment. It makes following a thread very hard since both posts will lack context.

It seems to work differently if I choose to share the link in MM.

biva commented 2 years ago

Indeed, sharing the link creates only 1 post, which is good :)

joho1968 commented 2 years ago

Yes, it is, it's great. My point is that I think uploading the file to MM with a comment should also only create one post, not two.

julien-nc commented 2 years ago

Thanks for the suggestion. Makes total sense and was not so hard-ish to implement. It was even worse than what you said, each file was in a separate post (when sending multiple at once).

All files are now in the same post, comment in the same post as the files. :heavy_check_mark:

This is included in v1.0.3-2-nightly if you wanna try it. Otherwise, wait for the next release, coming soon.

joho1968 commented 2 years ago

Oh, I didn't even try the multiple files variant; yeah, that would have been "odd" to see in action 😳 🤔

Glad you went "all the way" with this, your implementation sounds exactly like I think it should be done. Great stuff!